On Fri, Jan 14, 2011 at 3:45 PM, Marti Raudsepp <ma...@juffo.org> wrote: > There's a similar case with CREATE TABLE IF NOT EXISTS, maybe this is > worth covering in an updated patch too? > And if I change that, people might expect the same from DROP X IF EXISTS too?
It's far less clear what you'd change those cases to say, and they already emit a NOTICE, so it seems unnecessary. >> Also, I don't really like the way this spreads knowledge of the >> completionTag out all over the backend. I think it would be better to >> follow the existing model used by the COPY and COMMIT commands, >> whereby the return value indicates what happened and >> standard_ProcessUtility() uses that to set the command tag. > > Right. I created this pattern after PerformPortalFetch() which already > took a completionTag argument. But your approach seems more > reasonable. OK. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
