On Sun, Jan 16, 2011 at 18:18, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: >>> + * The file will be named base.tar[.gz] if it's for the main data directory >>> + * or <tablespaceoid>.tar[.gz] if it's for another tablespace. >>> >>> Well we have UNIQUE, btree (spcname), so maybe we can use that here? > >> We could, but that would make it more likely to run into encoding >> issues and such - do we restrict what can be in a tablespace name? > > No. Don't even think of going there --- we got rid of user-accessible > names in the filesystem years ago and we're not going back. Consider > CREATE TABLESPACE "/foo/bar" LOCATION '/foo/bar';
Well, we'd try to name the file for that "<oid>-/foo/bar.tar", which I guess would break badly, yes. I guess we could normalize the tablespace name into [a-zA-Z0-9] or so, which would still be useful for the majority of cases, I think? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
