On Sun, Jan 16, 2011 at 2:30 PM, Andy Colson <a...@squeakycode.net> wrote: > I reviewed a couple patched, and I added my review to the commitfest page. > > If I find a problem, its obvious I should mark the patch as "returned with > feedback".
Only if it's got sufficiently serious flaws that getting it committed during this CommitFest is not practical. If it just needs some revision, "Waiting on Author" is the right place. > But what if I'm happy with it? I'm not a hacker so cannot do C code review, > should I leave it alone? Mark it as "ready for committer"? Yep, that's fine. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
