Apologies - I meant to CC in the list but forgot. I have gone through and changed all the related functions except ``update_attstats''.
Do you have any advice of how to handle the inner loops, such as those initializing ``stakindN''. The entries before can be handled just like in this patch, by using the symbolic constants. Again, this is based on master and all existing tests pass. Regards Richard --- On Mon, 13/6/11, richhguard-monot...@yahoo.co.uk <richhguard-monot...@yahoo.co.uk> wrote: > From: richhguard-monot...@yahoo.co.uk <richhguard-monot...@yahoo.co.uk> > Subject: Re: [HACKERS] PATCH: CreateComments: use explicit indexing for > ``values'' > To: "Tom Lane" <t...@sss.pgh.pa.us> > Date: Monday, 13 June, 2011, 21:08 > I have gone through and changed all > the related functions except ``update_attstats''. > > Do you have any advice of how to handle the inner loops, > such as those initializing ``stakindN''. The entries before > can be handled just like in this patch, by using the > symbolic constants. > > Again, this is based on master and all existing tests > pass. > > Regards > Richard > > --- On Mon, 13/6/11, Tom Lane <t...@sss.pgh.pa.us> > wrote: > > > From: Tom Lane <t...@sss.pgh.pa.us> > > Subject: Re: [HACKERS] PATCH: CreateComments: use > explicit indexing for ``values'' > > To: richhguard-monot...@yahoo.co.uk > > Cc: "Robert Haas" <robertmh...@gmail.com>, > pgsql-hackers@postgreSQL.org > > Date: Monday, 13 June, 2011, 16:09 > > I wrote: > > >> Historically this i++ approach has been used > in a > > lot of places that > > >> fill in system catalog tuples. We've fixed > > some of them over > > >> time, but I doubt this is the only one > > remaining. If we're going > > >> to try to remove it here, maybe we ought to > try to > > fix them all > > >> rather than just this one. > > > > A quick grep reveals that the places that still do it > that > > way are > > > > OperatorShellMake > > OperatorCreate > > TypeShellMake > > TypeCreate > > update_attstats (though this one might be hard to > improve) > > CreateComments > > CreateSharedComments > > InsertRule > > > > Of these, all but the two in comment.c follow the > > convention of > > mentioning the assigned-to column in a comment, so > that the > > code > > is at least somewhat greppable. So those two > > definitely need > > improvement, but should we consider changing the > others > > while at it? > > > > BTW, there are some contrib modules with > > functions-returning-record that > > fill in result tuples this way as well. But we > don't > > have symbolic > > constants for the column numbers there, and it's > probably > > not worth > > introducing such. > > > > > > regards, tom lane > > -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
