On Mon, Jun 13, 2011 at 9:09 PM, Alvaro Herrera <alvhe...@commandprompt.com> wrote:
> I noticed that pgbench's doCustom (the function highest in the profile > posted) returns doing nothing if the connection is supposed to be > "sleeping"; seems an open door for busy waiting. I didn't check the > rest of the code to see if there's something avoiding that condition. Yes, there is a "select" in threadRun that avoids that. Also, I don't think anyone would but in a "sleep" in this particular type of pgbench run. > I > also noticed that it seems to be very liberal about calling > INSTR_TIME_SET_CURRENT in the same function which perhaps could be > optimizing by calling it a single time at entry and reusing the value, > but I guess that would show up in the profile as a kernel call so it's > maybe not a problem. I think that only gets called when you specifically asked for latencies or for logging, or when making new connection (which should be rare) Cheers, Jeff -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
