2011/6/21 Alvaro Herrera <alvhe...@commandprompt.com>: > Excerpts from Pavel Stehule's message of mar jun 21 00:59:44 -0400 2011: > >> yes - it has a sense. Quoting changes sense from keyword to literal. >> But then I see a significant inconsistency - every know keywords >> should be only tokens. >> >> else if (strcmp(token, "pamservice") == 0) >> - { >> - REQUIRE_AUTH_OPTION(uaPAM, "pamservice", "pam"); >> - parsedline->pamservice = pstrdup(c); >> - } >> >> because >>pamservice<< - is known keyword, but 'pamservice' is some >> literal without any mean. You should to use a makro token_is_keyword >> more often. > > Yeah, I wondered about this too (same with auth types, i.e. do we accept > quoted "hostssl" and so on or should that by rejected?). I opted for > leaving it alone, but maybe this needs to be fixed. (Now that I think > about it, what we should do first is verify whether it works with quotes > in the unpatched code). >
It's question about compatibility - sure. But a description inside pg_hba.conf speaks cleanly - quoting means a lost of original semantic. And if we allow a quoting somewhere, then I can't imagine a description - "somewhere quoting means a string literal, somewhere have not impact?" Regards Pavel Stehule > -- > Álvaro Herrera <alvhe...@commandprompt.com> > The PostgreSQL Company - Command Prompt, Inc. > PostgreSQL Replication, Consulting, Custom Development, 24x7 support > -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers