On Thu, Jun 9, 2011 at 10:27 PM, Josh Kupershmidt <schmi...@gmail.com> wrote: > On Wed, Jun 8, 2011 at 6:36 PM, Brar Piening <b...@gmx.de> wrote: >> I tried to look at everything and cover everthing but please consider that >> this is my first review so please have a second look at it! > > I took a look at this as well, and I didn't encounter any problems > either. The patch is surprisingly small, but it looks like all the > documentation spots got covered, and I didn't see any missing pieces; > pg_dump copes fine, I didn't try pg_upgrade but I wouldn't expect > problems there either. > > Actually, the one piece I think could be added is a regression test. I > didn't see any existing tests that covered bigserial/serial8, either, > so I went ahead and added a few tests for smallerial and bigserial. I > didn't see the testcases Brar posted at first, or I might have adopted > a few from there, but this should cover basic use of smallserial.
Committed the main patch, and your regression tests. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
