On Tue, Jan 24, 2012 at 1:03 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > I wrote: >> Also, it occurs to me that an intermediate macro >> "PG_USED_FOR_ASSERTS_ONLY" would be a good idea, first because it >> documents *why* you want to mark the variable as possibly unused, >> and second because changing the macro definition would provide an easy way >> to check for totally-unused variables, in case we wanted to periodically >> make such checks. > > Uh, wait a second. Why not > > #ifdef USE_ASSERT_CHECKING > #define PG_USED_FOR_ASSERTS_ONLY > #else > #define PG_USED_FOR_ASSERTS_ONLY __attribute__((unused)) > #endif > > Then, when you build with asserts on, you *automatically* get told > if the variable is entirely unused.
Yes, that's what I meant when I suggested it originally. I'm just not sure it's any nicer than adding ifdefs for USE_ASSERT_CHECKING. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
