On Sat, Jan 28, 2012 at 3:32 PM, Jeff Janes <jeff.ja...@gmail.com> wrote: >> I think that even in normal (non-initialization) usage, this message >> should be suppressed when the provided scale factor >> is equal to the pgbench_branches table count. > > The attached patch does just that. There is probably no reason to > warn people that we are doing what they told us to, but not for the > reason they think.
In my opinion, a more sensible approach than anything we're doing right now would be to outright *reject* options that will only be ignored. If -s isn't supported except with -i, then trying to specify -s without -i should just error out at the options-parsing stage, before we even try to connect to the database. It's not very helpful to accept options and then ignore them, and we have many instances of that right now: initialization-only switches are accepted and ignored when not initializing, and run-only switches are accepted and ignored with initializing. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
