On Thursday, May 24, 2012, Thom Brown wrote: > On 24 May 2012 13:37, Magnus Hagander <mag...@hagander.net <javascript:;>> > wrote: > > On Thu, May 24, 2012 at 2:34 PM, Thom Brown <t...@linux.com<javascript:;>> > wrote: > >> On 24 May 2012 13:05, Magnus Hagander <mag...@hagander.net<javascript:;>> > wrote: > >>> On Thu, Apr 19, 2012 at 1:00 PM, Thom Brown <t...@linux.com<javascript:;>> > wrote: > >>>> On 10 April 2012 21:07, Magnus Hagander > >>>> <mag...@hagander.net<javascript:;>> > wrote: > >>>>> On Friday, April 6, 2012, Thom Brown wrote: > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>> I've tried out pg_receivexlog and have noticed that when restarting > >>>>>> the cluster, pg_receivexlog gets cut off... it doesn't keep waiting. > >>>>>> This is surprising as the DBA would have to remember to start > >>>>>> pg_receivexlog up again. > >>>>>> > >>>>> > >>>>> This is intentional as far as that's how the code was written, > there's not a > >>>>> malfunctioning piece of code somewhere. > >>>>> > >>>>> It would probably make sense to have an auto-reconnect feature, and > to have > >>>>> an option to turn it on/off. > >>>>> > >>>>> If you haven't already (my wifi here is currently quite useless, > which is > >>>>> why I'm working on my email backlog, so I can't check), please add > it to the > >>>>> open items list. > >>>> > >>>> I think it would also be useful to add a paragraph to the > >>>> documentation stating use-cases for this feature, and its advantages. > >>> > >>> Attached is a patch that implements this. Seems reasonable? > >> > >> s/non fatal/non-fatal/ > >> > >> Yes, this solves the problem for me, except you forgot to translate > >> noloop in long_options[] . :) > > Fixed :-) > > > > Did you test it, or just assumed it worked? ;) > > How very dare you. Of course I tested it. It successfully reconnects > on multiple restarts, checks intermittently when I've stopped the > server, showing the connection error message, successfully continues > when I eventually bring the server back up, and doesn't attempt a > reconnect when using -n. > > So looks good to me. >
Thanks - applied! -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
