2012/9/21 Tatsuo Ishii <is...@postgresql.org>: >>>> Hmm, I see. Please deliver the 64bit integer argument as reference, >>>> and don't forget endian translations here. >>> >>> I thought pgPutInt64() takes care of endianness. No? >>> >> It works inside of the PGfn(), when isint = 1 towards pointer data type. >> In my sense, it is a bit problem specific solution. >> >> So, I'd like to see other person's opinion here. > > I think we cannot change this because we want to keep the counter part > backend side function pq_getmsgint64() as it is (the function is not > part of the patch). > My opinion is lo_lseek64() and lo_tell64() should handle endian translation prior and next to PQfn() invocation; to avoid the int64 specific case-handling inside of PQfn() that can be called by other applications.
Am I missing something? Thanks, -- KaiGai Kohei <kai...@kaigai.gr.jp> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
