On 20 December 2012 13:19, Amit Kapila <amit.kap...@huawei.com> wrote:
>> So I think we're good on that front. But I'll add a comment there, and >> use 0 explicitly instead of ThisTimeLineID, for clarity. > > True, it might not have any functionality effect in RemoveOldXlogFiles(). > However it can be used in PreallocXlogFiles()->XLogFileInit() as well. PreallocXlogFiles() should have been put to the sword long ago. It's a performance tweak aimed at people without a performance problem in this area. I'll happily accept this excuse to remove it. We can discuss whether any replacement is required. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
