On 2012-12-20 13:32:36 +0000, Simon Riggs wrote: > On 20 December 2012 13:19, Amit Kapila <amit.kap...@huawei.com> wrote: > > >> So I think we're good on that front. But I'll add a comment there, and > >> use 0 explicitly instead of ThisTimeLineID, for clarity. > > > > True, it might not have any functionality effect in RemoveOldXlogFiles(). > > However it can be used in PreallocXlogFiles()->XLogFileInit() as well. > > PreallocXlogFiles() should have been put to the sword long ago. It's a > performance tweak aimed at people without a performance problem in > this area.
Creating, zeroing & fsync()'ing a 16MB file shouldn't be done in individual transactions because it would increase latency noticeably. So it seems it addresses a real performance problem. What do you dislike about it? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
