On Mon, Jan 21, 2013 at 2:09 PM, Josh Berkus <j...@agliodbs.com> wrote: >> But even before that, you have to ask whether what it's supposed to do >> is something we want. > > The reviewer can't usually answer that though.
They can answer whether THEY want it, though. And Tom, Andrew, and I all just got through arguing that that is one of the most, if not the most, important parts of a review. Seriously. Opinions are good. Lack of opinions leads to "ivory tower" syndrome, which of course we've got, but I think most of us are sufficiently self-aware to at least know that it isn't a good thing. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
