On Mon, Jan 21, 2013 at 12:27 PM, Dimitri Fontaine <dimi...@2ndquadrant.fr> wrote: > Please find it attached to this email.
Nice clean patch, thanks! Committed, after tinkering with the CommandCounterIncrement() stuff a bit. I will respond to the rest of your email later. Reading through this patch left me with a slight concern regarding both ddl_command_start and ddl_command_end: what happens if there's more than one event trigger scheduled to fire, and one of them does something like drop (with cascade) the function that a later one uses? Admittedly, that seems like an unlikely case, but we probably want to check that nothing too awful happens (e.g. crashing the server) and maybe add a regression test to cover this scenario. Another thing is that we might want to document that if a command errors out, ddl_command_end will never be reached; and perhaps also that if ddl_command_start errors out, the command itself will never be reached. Perhaps this is so obvious as to not bear mentioning, I don't know, but the thought crossed my mind that someone might fail to realize it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
