Alvaro Herrera <alvhe...@2ndquadrant.com> writes:
>       xid = HeapTupleHeaderGetRawXmax(tuple);
> !     if (((tuple->t_infomask & HEAP_XMAX_IS_MULTI) &&
> !              MultiXactIdIsValid(xid) &&
> !              MultiXactIdPrecedes(xid, cutoff_multi)) ||
> !             ((!(tuple->t_infomask & HEAP_XMAX_IS_MULTI)) &&
> !              TransactionIdIsNormal(xid) &&
> !              TransactionIdPrecedes(xid, cutoff_xid)))
>       {

Would this be clearer as a ternary expression?  That is,

        if ((tuple->t_infomask & HEAP_XMAX_IS_MULTI) ?
                (MultiXactIdIsValid(xid) &&
                 MultiXactIdPrecedes(xid, cutoff_multi)) :
                (TransactionIdIsNormal(xid) &&
                 TransactionIdPrecedes(xid, cutoff_xid)))

                        regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to