Alvaro Herrera escribió: > c. I added the MSVC bits. I tested that most of it works, but the > various regress executables as well as zic failed to build due to > lack of libpgcommon at link time. I think I fixed it; I'm waiting on > new tests to run. (This patch is the fixed version).
The attached is all that's necessary on top of the submitted v2 to make it build on MSVC. Barring objections, I will push this. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
commit 486f297229c321e02b628c415d17f971ad3cd7b9 Author: Alvaro Herrera <alvhe...@alvh.no-ip.org> Date: Mon Feb 11 19:10:56 2013 -0300 ecpg needs libpgcommon, too diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm index 0642662..75e7e41 100644 --- a/src/tools/msvc/Mkvcbuild.pm +++ b/src/tools/msvc/Mkvcbuild.pm @@ -313,7 +313,7 @@ sub mkvcbuild $ecpg->AddDefine('MINOR_VERSION=9'); $ecpg->AddDefine('PATCHLEVEL=0'); $ecpg->AddDefine('ECPG_COMPILE'); - $ecpg->AddReference($libpgport); + $ecpg->AddReference($libpgport, $libpgcommon); my $pgregress_ecpg = $solution->AddProject('pg_regress_ecpg', 'exe', 'misc');
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers