Hello 2013/2/28 Dean Rasheed <dean.a.rash...@gmail.com>: > On 28 February 2013 11:25, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: >> Umm. sorry, >> >>> If you have no problem with this, I'll send this to committer. >> >> I just found that this patch already has a revewer. I've seen >> only Status field in patch list.. >> >> Should I leave this to you, Dean? >> > > Sorry, I've been meaning to review this properly for some time, but > I've been swamped with other work, so I'm happy for you to take over. > > My overall impression is that the patch is in good shape, and provides > valuable new functionality, and it is probably close to being ready > for committer. > > I think that the only other behavioural glitch I spotted was that it > fails to catch one overflow case, which should generate an "out of > ranger" error: > > select format('|%*s|', -2147483648, 'foo'); > Result: |foo| > > because -(-2147483648) = 0 in signed 32-bit integers.
fixed - next other overflow check added Regards Pavel > > Apart from that, I didn't find any problems during my testing. > > Thanks for your review. > > Regards, > Dean
format-width-20130301.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers