On Tue, Mar 5, 2013 at 10:35 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > Thanks for the review. All your comments are addressed and updated patches > are attached.
I got the compile warnings: tuptoaster.c:1539: warning: format '%s' expects type 'char *', but argument 3 has type 'Oid' tuptoaster.c:1539: warning: too many arguments for format The patch doesn't handle the index on the materialized view correctly. =# CREATE TABLE hoge (i int); CREATE TABLE =# CREATE MATERIALIZED VIEW hogeview AS SELECT * FROM hoge; SELECT 0 =# CREATE INDEX hogeview_idx ON hogeview(i); CREATE INDEX =# REINDEX TABLE hogeview; REINDEX =# REINDEX TABLE CONCURRENTLY hogeview; NOTICE: table "hogeview" has no indexes REINDEX Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
