On Tue, Mar 5, 2013 at 11:22 PM, Fujii Masao <masao.fu...@gmail.com> wrote:
> On Tue, Mar 5, 2013 at 10:35 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: > > Thanks for the review. All your comments are addressed and updated > patches > > are attached. > > I got the compile warnings: > tuptoaster.c:1539: warning: format '%s' expects type 'char *', but > argument 3 has type 'Oid' > tuptoaster.c:1539: warning: too many arguments for format > Fixed. Thanks for catching that. > The patch doesn't handle the index on the materialized view correctly. > Hehe... I didn't know that materialized views could have indexes... I fixed it, will send updated patch once I am done with Andres' comments. -- Michael
