On Fri, Apr 19, 2013 at 11:12 AM, Robert Haas <robertmh...@gmail.com> wrote:

> On Fri, Apr 19, 2013 at 10:05 AM, Fabrízio de Royes Mello
> <fabriziome...@gmail.com> wrote:
> > The attached wip patch do that and introduce a subcommand 'SEQUENCES',
> but
> > if we decide to don't add a new subcommand to DISCARD, then its easier to
> > modify the patch.
>
> This patch is quite wrong.  It frees seqtab without clearing the
> pointer, so the next reference will stomp on memory that may have been
> reallocated.  And it doesn't even free seqtab correctly, since it only
> frees the first node in the linked list.
>
>
Ohh sorry... you're all right... I completely forgot to finish the
ReleaseSequenceCaches to transverse 'seqtab' linked list and free each
node.

The attached patch have this correct code.

Regards,

-- 
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello

Attachment: discard_sequences.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to