Tom Lane wrote:
> Alvaro Herrera <alvhe...@2ndquadrant.com> writes:

> > Here's the second attachment.
> 
> This looks good except that it can't tell "db_123.statfoo" isn't a match.
> The scan limit/buffer size needs to be greater than the longest string
> you care about, not only equal to.  I think strcmp not strncmp would be
> better coding, too.  Please fix that and commit -- I think this part
> is pretty noncontroversial.

Pushed with those fixes, thanks.  I noticed we also needed to match
files global.stat and global.tmp.  Also I added another conversion to
the sscanf pattern, to ignore files named "db_1234.tmp.foo" and such
(i.e.  stuff after whitespace).

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to