On Tue, Sep 17, 2013 at 11:31 PM, Andres Freund <and...@2ndquadrant.com> wrote: > On 2013-09-17 09:45:28 -0400, Peter Eisentraut wrote: >> On 9/15/13 11:30 AM, Andres Freund wrote: >> > On 2013-09-15 11:20:20 -0400, Peter Eisentraut wrote: >> >> On Sat, 2013-09-14 at 22:49 +0200, Andres Freund wrote: >> >>> Attached you can find the newest version of the logical changeset >> >>> generation patchset. >> >> >> >> You probably have bigger things to worry about, but please check the >> >> results of cpluspluscheck, because some of the header files don't >> >> include header files they depend on. >> > >> > Hm. I tried to get that right, but it's been a while since I last >> > checked. I don't regularly use cpluspluscheck because it doesn't work in >> > VPATH builds... We really need to fix that. >> > >> > I'll push a fix for that to the git tree, don't think that's worth a >> > resend in itself. >> >> This patch set now fails to apply because of the commit "Rename various >> "freeze multixact" variables". > > And I am even partially guilty for that patch... > > Rebased patches attached.
When I applied all the patches and do the compile, I got the following error: gcc -O0 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -g -I. -I../../../../src/include -D_GNU_SOURCE -c -o snapbuild.o snapbuild.c snapbuild.c:187: error: redefinition of typedef 'SnapBuild' ../../../../src/include/replication/snapbuild.h:45: note: previous declaration of 'SnapBuild' was here make[4]: *** [snapbuild.o] Error 1 When I applied only 0001-wal_decoding-Allow-walsender-s-to-connect-to-a-speci.patch, compiled the source, and set up the asynchronous replication, I got the segmentation fault. LOG: server process (PID 12777) was terminated by signal 11: Segmentation fault Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers