On Sun, 2013-09-15 at 18:27 +0200, Marko Tiikkaja wrote: > I think the reasoning behind this patch is sound. However, I would like > to raise a couple of small questions: > > 1) Is there a reason for the fmt string not being const char*? You > changed it for pg_log_v(), but not for pg_log() and pg_fatal().
Good catch. I think I just left the existing code alone. I'll fix it. > 2) Allowing PG_FATAL to be passed to pg_log() seems weird, but I > don't feel strongly about that. Yeah, it's a bit weird. It's just because it all ends up in pg_log_v(). We could have pg_log() error about it, but that seems a bit excessive. It's not a public API or anything. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
