On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote: > On 10/07/2013 08:47 PM, Peter Eisentraut wrote: > > > > I suspect this line > > > > submake-libpq: $(libdir)/libpq.so ; > > > > will cause problems on platforms with a different extension (e.g. OS X). > > > suggested fix is below.
Hmm, this would duplicate information about shared library naming in a place outside of Makefile.shlib. That doesn't look right. > diff --git a/src/Makefile.global.in b/src/Makefile.global.in > index bb732bb..b562378 100644 > --- a/src/Makefile.global.in > +++ b/src/Makefile.global.in > @@ -422,7 +422,11 @@ ifndef PGXS > submake-libpq: > $(MAKE) -C $(libpq_builddir) all > else > -submake-libpq: $(libdir)/libpq.so ; > +ifneq ($(PORTNAME),cygwin) > +submake-libpq: $(libdir)/libpq$(DLSUFFIX) ; > +else > +submake-libpq: $(libdir)/cygpq$(DLSUFFIX) ; > +endif > endif > > ifndef PGXS > > > -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
