Robert Haas escribió: > I'm not inclined to wait for the next CommitFest to commit this, > because it's a very simple patch and has already had a lot more field > testing than most patches get before they're committed. And it's just > a contrib module, so the damage it can do if there is in fact a bug is > pretty limited. All that having been said, any review is appreciated.
Looks nice. Some really minor things I noticed while skimming are that you have some weird indentation using spaces in some ereport() calls; there's an extra call to RelationOpenSmgr() in read mode; and the copyright year is 2012. Please use — in sgml instead of plain dashes, and please avoid the "!strcmp()" idiom. I didn't actually try it out ... -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
