On Tue, Feb 4, 2014 at 11:56 PM, Heikki Linnakangas <hlinnakan...@vmware.com> wrote: >> Since, as I mentioned, _bt_finish_split() ultimately unlocks *and >> unpins*, it may not be the same buffer as before, so even with the >> refactoring there are race conditions. > > Care to elaborate? Or are you just referring to the missing "buf = " ?
Yes, that's all I meant. > Attached is a new version of the patch, with those issues fixed. > btree-incomplete-split-4.patch is a complete patch against the latest > fix-btree-page-deletion patch, and moveright-assign-fix.patch is just the > changes to _bt_moveright, if you want to review just the changes since the > previous patch I posted. Cool. I'll take a good look at it tomorrow morning PST. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
