On 2014-02-15 14:35:02 -0500, Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > > Patch attached. > > Committed with some cosmetic adjustments --- thanks! > > > I am not sure whether HAVE_GETOPT is the best condition > > to use, since it's set by configure by a link based check, same goes for > > HAVE_INT_OPTERR. The other choices would be relying on HAVE_GETOPT_H or > > a new AC_CHECK_DECL. > > I'm pretty sure HAVE_GETOPT is *not* what we want to use for the variable > declarations. I've tried HAVE_GETOPT_H for the moment, but that may need > more tweaking depending on what the buildfarm has to say.
I only used it because it was what previously protected the getopt() declaration in port.h... But that should probably have been depending on !HAVE_GETOPT_H in the first place. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
