On 2014-04-08 12:15:47 -0400, Greg Stark wrote: > With no doc changes and no regression tests I was halfway inclined to > just reject it out of hand. To be fair there were no regression tests > for wrapped output prior to the patch but still I would have wanted to > see them added. We often pare down regression tests when committing > patches but it's easier to pare them down than write new ones and it > helps show the author's intention.
I don't think this is easily testable that way - doesn't it rely on determining the width of the terminal? Which you won't have when started from pg_regress? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
