Hello There are lot of unnecessary block over one statement in code
+ if ((inAutoX) && (chunk == events->head) && ((char *)event < afterTriggers->events_stack[my_level].tailfree)) + { + continue; + } + and there a few too long lines Regards Pavel 2014-06-24 18:40 GMT+02:00 Pavel Stehule <pavel.steh...@gmail.com>: > postgres=# select version(); > > version > > ----------------------------------------------------------------------------------------------------------------- > PostgreSQL 9.5devel on x86_64-unknown-linux-gnu, compiled by gcc (GCC) > 4.8.2 20131212 (Red Hat 4.8.2-7), 64-bit > (1 row) > > > > 2014-06-24 18:39 GMT+02:00 Pavel Stehule <pavel.steh...@gmail.com>: > > Hello >> >> regress tests fails: >> >> plancache ... ok >> limit ... ok >> plpgsql ... ok >> copy2 ... ok >> temp ... FAILED >> domain ... ok >> rangefuncs ... ok >> prepare ... ok >> without_oid ... ok >> conversion ... ok >> truncate ... ok >> alter_table ... ok >> sequence ... ok >> >> I did some small tests and it works well. When I looked to code, I was >> surprised by hardcoded max nesting level of autonomous transactions >> >> #define MAX_AUTOX_NESTING_LEVEL 3 >> >> why? Is not it too restrictive? >> >> I am missing a regress tests. >> >> Regards >> >> Pavel >> >> >> >> >> >> >> 2014-06-18 11:19 GMT+02:00 Rajeev rastogi <rajeev.rast...@huawei.com>: >> >>> On 17 June 2014 02:01, Alvaro Herrera Wrote: >>> >>> > What's the status of this patch? >>> >>> I have completed work on this and some more changes are done on top of >>> earlier patch shared: >>> 1. Fixed all of the issues observed. >>> 2. Addressed some of the feedback from community like >>> a. Change the syntax to >>> START AUTONOMOUS TRANSACTION [READ ONLY | READ >>> WRITE] >>> b. As Pavan had pointed, I have made transaction behavior (only >>> read-only properties) of main and autonomous transaction independent. >>> 3. Added documentation for this feature. >>> 4. Rebased to latest git code. >>> >>> Please find the attached latest patch and provide opinion. >>> >>> Thanks and Regards, >>> Kumar Rajeev Rastogi >>> >>> >>> >>> -- >>> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgsql-hackers >>> >>> >> >