Peter Eisentraut wrote: > Bruce Momjian writes: > > > I am concerned about one more thing. On BSD/OS, we have off_t of quad > > (8 byte), but we don't have fseeko, so this call looks questionable: > > > > if (fseeko(AH->FH, tctx->dataPos, SEEK_SET) != 0) > > Maybe you want to ask your OS provider how the heck this is supposed to > work. I mean, it's great to have wide types, but what's the point if the > API can't handle them?
Excellent question. They do have fsetpos/fgetpos, and I think they think you are supposed to use those. However, they don't do seek from current position, and they don't take an off_t, so I am confused myself. I did ask on the mailing list and everyone kind of agreed it was a missing feature. However, because of the way we call fseeko not knowing if it is a quad or a long, I think we have to add the checks to prevent such wild seeks from happening. -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 6: Have you searched our list archives? http://archives.postgresql.org
