On Wed, Aug 27, 2014 at 12:31 PM, Fujii Masao <masao.fu...@gmail.com> wrote:
> On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier
> <michael.paqu...@gmail.com> wrote:
> I think that it's better to add an include guard like
>
> #ifndef RECEIVELOG_H
> #define RECEIVELOG_H
> ...
> #endif
Oh indeed, that was missing as well! Please see attached.
-- 
Michael
diff --git a/src/bin/pg_basebackup/receivelog.h b/src/bin/pg_basebackup/receivelog.h
index 72f8245..36eb1e1 100644
--- a/src/bin/pg_basebackup/receivelog.h
+++ b/src/bin/pg_basebackup/receivelog.h
@@ -1,3 +1,17 @@
+/*-------------------------------------------------------------------------
+ *
+ * receivelog.h
+ *
+ * Portions Copyright (c) 1996-2014, PostgreSQL Global Development Group
+ *
+ * IDENTIFICATION
+ *		  src/bin/pg_basebackup/receivelog.h
+ *-------------------------------------------------------------------------
+ */
+
+#ifndef RECEIVELOG_H
+#define RECEIVELOG_H
+
 #include "libpq-fe.h"
 
 #include "access/xlogdefs.h"
@@ -18,3 +32,5 @@ extern bool ReceiveXlogStream(PGconn *conn,
 				  int standby_message_timeout,
 				  char *partial_suffix,
 				  int fsync_interval);
+
+#endif	/* RECEIVELOG_H */
diff --git a/src/bin/pg_basebackup/streamutil.h b/src/bin/pg_basebackup/streamutil.h
index c36a37b..8c6691f 100644
--- a/src/bin/pg_basebackup/streamutil.h
+++ b/src/bin/pg_basebackup/streamutil.h
@@ -1,3 +1,17 @@
+/*-------------------------------------------------------------------------
+ *
+ * streamutil.h
+ *
+ * Portions Copyright (c) 1996-2014, PostgreSQL Global Development Group
+ *
+ * IDENTIFICATION
+ *		  src/bin/pg_basebackup/streamutil.h
+ *-------------------------------------------------------------------------
+ */
+
+#ifndef STREAMUTIL_H
+#define STREAMUTIL_H
+
 #include "libpq-fe.h"
 
 extern const char *progname;
@@ -22,3 +36,5 @@ extern bool feTimestampDifferenceExceeds(int64 start_time, int64 stop_time,
 							 int msec);
 extern void fe_sendint64(int64 i, char *buf);
 extern int64 fe_recvint64(char *buf);
+
+#endif	/* STREAMUTIL_H */
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to