On 09/02/2014 04:12 PM, Alvaro Herrera wrote: > Fujii Masao wrote: >> On Mon, Sep 1, 2014 at 10:54 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >>> On Mon, Sep 1, 2014 at 3:57 PM, Fujii Masao <masao.fu...@gmail.com> wrote: >>>> >>>> On Sat, Aug 30, 2014 at 12:27 PM, Amit Kapila <amit.kapil...@gmail.com> >>>> wrote: >>>>> On Wed, Aug 27, 2014 at 7:16 PM, Fujii Masao <masao.fu...@gmail.com> >>>>> wrote: >>>>>> The patch looks good to me. One minor comment is; probably you need to >>>>>> update the tab-completion code. >>>>> >>>>> Thanks for the review. I have updated the patch to support >>>>> tab-completion. >>>>> As this is a relatively minor change, I will mark it as >>>>> "Ready For Committer" rather than "Needs Review". >>>> >>>> Thanks for updating the patch! >>>> >>>> One more minor comment is; what about applying the following change >>>> for the tab-completion for RESET ALL? This causes the tab-completion of >>>> even ALTER SYSTEM SET to display "all" and that's strange. But >>>> the tab-completion of "SET" has already had the same problem. So >>>> I think that we can live with that. >>> >>> Right and I have checked that behaviour is same for other similar >>> statements like Alter Database <database_name> SET <config_var> >>> or Alter User <user_name> SET <config_var>. So, the change >>> made by you is on similar lines. >> >> OK. Applied. > > Uhm, are we agreed on the decision on not to backpatch this? I would > think this should have been part of the initial ALTER SYSTEM SET patch > and thus should be backpatched to 9.4.
I think it belongs in 9.4 as well, especially if we're having another beta. -- Vik -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
