On 10/01/2014 01:32 PM, Andres Freund wrote:
On 2014-10-01 13:22:53 -0400, Jan Wieck wrote:
On 10/01/2014 01:19 PM, Andres Freund wrote:
>On 2014-10-01 13:17:17 -0400, Jan Wieck wrote:
>>>>-static void StreamLog();
>>>>+static void StreamLogicalLog();
>>>>Not related at all to those patches, but for correctness it is better to
>>>>add a declaration "(void)".
>>>
>>>Agreed.
>>>
>>>>Except those small things the changes look good to me.
>>>
>>>Cool. Will push and then, sometime this week, review the next patch.
>
>>You might want to do that function renaming in pg_receivexlog.c as well.
>
>Why? You mean to StreamPhysicalLog()?
Like that.
Don't see that much point - it just seemed wrong to have StreamLog do
two somewhat different things. And StreamLog() in receivexlog is much older...
The point is that StreamLog is semantically a superset of StreamWhateverLog.
Jan
Plus, there is one more occurrence of StreamLog() in pg_recvlogical.c.
Gah. Wrongly split commit :(. Fixed in 9.4, it's already fixed by the
subsequent commit in master.
Greetings,
Andres Freund
--
Jan Wieck
Senior Software Engineer
http://slony.info
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
