On Mon, Jan 19, 2015 at 11:16 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> Sure, but nobody who is not a developer is going to care about that. >> A typical user who sees "pgstat wait timeout", or doesn't, isn't going >> to be able to make anything at all out of that. > > Possibly we need to improve the wording of that error message then. > When it was written, we really assumed that it was a can't-happen case > and so didn't spend much effort on it. Perhaps it should become a > translatable ereport phrased like "WARNING: using stale statistics > instead of current ones because stats collector is not responding".
I'm still not completely convinced it deserves to be a WARNING, but I definitely think turning it into a translatable error message is the right call. Calling this a "can't happen" case is clearly ridiculous at this point. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
