On Tue, Jan 20, 2015 at 5:46 PM, Peter Geoghegan <p...@heroku.com> wrote: > Would you prefer it if the spill-to-disk case > aborted in the style of low entropy keys? That doesn't seem > significantly safer than this, and it certainly not acceptable from a > performance perspective.
BTW, I can write that patch if that's your preference. Should I? I just don't favor that even as a short term correctness fix, because it seems unacceptable to throw away all the strxfrm() work where that's a very predictable and even likely outcome. I suggest reviewing and committing my fix as a short term fix, that may well turn out to be generally acceptable upon further consideration. Yes, we'll need to make a point of reviewing an already committed patch, but there is a precedent for that. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
