On Fri, Jan 23, 2015 at 2:18 AM, David Rowley <dgrowle...@gmail.com> wrote: > On 20 January 2015 at 17:10, Peter Geoghegan <p...@heroku.com> wrote: >> >> On Mon, Jan 19, 2015 at 7:47 PM, Michael Paquier >> <michael.paqu...@gmail.com> wrote: >> >> > With your patch applied, the failure with MSVC disappeared, but there >> > is still a warning showing up: >> > (ClCompile target) -> >> > src\backend\lib\hyperloglog.c(73): warning C4334: '<<' : result of >> > 32-bit shift implicitly converted to 64 bits (was 64-bit shift >> > intended? >> >> That seems harmless. I suggest an explicit cast to "Size" here. > > This caught my eye too. > > I agree about casting to Size. > > Patch attached.
Thanks, committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
