On 2015-03-17 20:50:48 -0700, Peter Geoghegan wrote: > On Mon, Mar 16, 2015 at 6:22 AM, Petr Jelinek <p...@2ndquadrant.com> wrote: > >> Do you think it is ready for committer? > >> > > > > In my opinion, yes. > > If it wasn't for the autoconf parts of this, I'd probably agree with > you. I need to go over that more carefully.
I think it's a pretty direct copy of the 64bit code. I'm not entirely sure why this needs a AC_TRY_RUN with a compile fallback (for cross) and why a AC_TRY_LINK isn't sufficient? But then, you just copied that decision. Tom, it seems you have added the 64bit check to configure. All, the way back in 1998 ;). C.f. 07ae591c87. Do you see a reason why we need to actually run code? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
