On Tue, Jul 7, 2015 at 11:34 PM, Stephen Frost <sfr...@snowman.net> wrote: > * Fujii Masao (masao.fu...@gmail.com) wrote: >> On Tue, Jul 7, 2015 at 10:31 PM, Stephen Frost <sfr...@snowman.net> wrote: >> > I'm not following. If we don't want the information to be available to >> > everyone then we need to limit it, and right now the only way to do that >> > is to restrict it to superuser because we haven't got anything more >> > granular. >> >> A user can very easily limit such information by not enabling >> wal_compression. >> No need to restrict the usage of WAL location functions. >> Of course, as Michael suggested, we need to make the parameter SUSET >> so that only superuser can change the setting, though. > > I agree with making it SUSET, but that doesn't address the issue.
ISTM that one our consensus is to make wal_compression SUSET as the first step whatever approach we adopt for the risk in question later. So, barring any objection, I will commit the attached patch and change the context to PGC_SUSET. Regards, -- Fujii Masao
*** a/doc/src/sgml/config.sgml --- b/doc/src/sgml/config.sgml *************** *** 2303,2308 **** include_dir 'conf.d' --- 2303,2309 ---- <xref linkend="guc-full-page-writes"> is on or during a base backup. A compressed page image will be decompressed during WAL replay. The default value is <literal>off</>. + Only superusers can change this setting. </para> <para> *** a/src/backend/utils/misc/guc.c --- b/src/backend/utils/misc/guc.c *************** *** 995,1001 **** static struct config_bool ConfigureNamesBool[] = }, { ! {"wal_compression", PGC_USERSET, WAL_SETTINGS, gettext_noop("Compresses full-page writes written in WAL file."), NULL }, --- 995,1001 ---- }, { ! {"wal_compression", PGC_SUSET, WAL_SETTINGS, gettext_noop("Compresses full-page writes written in WAL file."), NULL },
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers