On 2015-09-06 19:05, Fabien COELHO wrote:
Here is a rebased two-part v11.
function parameters are always in the same line as the function name
ISTM that I did that, or maybe I did not understand what I've done wrong.
I see one instance of this issue
+static int
+NextBufferToWrite(
+ TableSpaceCheckpointStatus *spcStatus, int nb_spaces,
+ int *pspace, int num_to_write, int num_written)
Also
+static int bufcmp(const void * pa, const void * pb)
+{
should IMHO be formatted as
+static int
+bufcmp(const void * pa, const void * pb)
+{
And I think we generally put the struct typedefs at the top of the C
file and don't mix them with function definitions (I am talking about
the TableSpaceCheckpointStatus and TableSpaceCountEntry).
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
