On Tue, Sep 8, 2015 at 10:44 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Sep 8, 2015 at 6:14 AM, Petr Jelinek wrote: >> Attached patch uses just boolean in cascade DefElem and splits the >> CreateExtension into two functions, the cascade code now calls the >> CreateExtensionInternal. One thing though - I am passing the DefElems >> directly to the cascaded CreateExtensionStmt options, I think it's not >> problem but want to give it extra visibility. >> >> Also the schema check was moved. > > OK, passing the list of extensions through the new routine is indeed a > cleaner approach. One point of detail is that instead of doing this > part: > + /* Handle the CASCADE option. */ > + if (d_cascade) > + cascade = defGetBoolean(d_cascade); > + else > + cascade = false; > You may as well just initialize cascade to false at the beginning of > the routine and update it only if d_cascade is defined. > > Attached are as well changes for the documentation that I spotted in > earlier reviews but were not included in the last version sent by Petr > yesterday. Feel free to discard them if you think they are not > adapted, the patch attached applies on top of Petr's patch.
And /log/ is missing in src/test/modules/extensions/.gitignore. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
