On Tue, Sep 22, 2015 at 8:19 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Thomas Munro wrote: > >> In walsender.c, walreceiver.c, walreceiverfuncs.c there are several >> places where volatile qualifiers are used apparently only to prevent >> reordering around spinlock operations. > > In replication/slot.c there are a number of places (12, I think) that > introduce a block specifically to contain a volatile cast on a variable > for spinlock-protected access. We could remove the whole thing and save > at least 3 lines and one indentation level for each of them.
Right, see attached. -- Thomas Munro http://www.enterprisedb.com
replication-strip-volatile-v2.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
