On Tue, Jan 26, 2016 at 10:25 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Jan 26, 2016 at 9:52 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Tab completion for REFRESH command is oddly with following scenario. >> >> =# REFRESH MATERIALIZED VIEW CONCURRENTLY hoge_mv [Tab] >> >> It shows only WITH DATA option without WITH NO DATA option. >> Attached patch improves tab completion for WITH DATA/NO DATA option of >> REFRESH MATERIALIZED VIEW. > > Correct. Nice catch and good patch.
The patch looks good to me.
While testing the patch, I found that
REFRESH MATERIALIZED VIEW <tab> doesn't list the materialized views.
I added the following change to the patch to fix that problem. Patch attached.
- {"MATERIALIZED VIEW", NULL, NULL},
+ {"MATERIALIZED VIEW", NULL, &Query_for_list_of_matviews},
Regards,
--
Fujii Masao
improve_tab_completion_for_refresh_v2.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
