On Wed, Jan 27, 2016 at 11:41 AM, Fujii Masao <masao.fu...@gmail.com> wrote:
> But ISTM that CREATE MATERIALIZED VIEW <tab> doesn't list
> existing matviews yet. What's worse it lists existing *views*.
Yep.
> This happens because words_after_create mechanism doesn't support
> the case where the keyword has more than one words like "MATERIALIZED VIEW".
Having worked on that, I am not convinced this is worth the complication.
> Probably we should improve that mechanism so that even multiple words can be
> handled. Or we should just add something like the following.
>
> /* Complete CREATE MATERIALIZED VIEW with <name> */
> + else if (Matches3("CREATE", "MATERIALIZED", "VIEW"))
> + COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_matviews, NULL);
Indeed, we do the same for tables and views as well. That would be fine.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
