On 3/2/16 10:48 AM, Julien Rouhaud wrote:
Good point, I don't see a lot of information available with this hooks that a native system statistics couldn't offer. To have the same amount of information, I think we'd need a pg_stat_autovacuum view that shows a realtime insight of the workers, and also add some aggregated counters to PgStat_StatTabEntry. I wonder if adding counters to PgStat_StatTabEntry would be accepted though.
I would also really like to see a means of logging (auto)vacuum activity in the database itself. We figured out how to do that with pg_stat_statements, which was a lot harder... it seems kinda silly not to offer that for vacuum. Hooks plus shared memory data should allow for that (the only tricky bit is the hook would need to start and then commit a transaction, but that doesn't seem onerous).
I think the shared memory structures should be done as well. Having that real-time info is also valuable.
I don't see too much point in adding stuff to the stats system for this. -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Architecture and PostgreSQL Data in Trouble? Get it in Treble! http://BlueTreble.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
