On Fri, Mar 4, 2016 at 4:20 PM, Amit Kapila <amit.kapil...@gmail.com> wrote:
> On Fri, Mar 4, 2016 at 4:01 PM, Alexander Korotkov <aekorot...@gmail.com> > wrote: > >> On Fri, Mar 4, 2016 at 7:05 AM, Amit Kapila <amit.kapil...@gmail.com> >> wrote: >> >>> > I think the wait event types should be documented - and the wait >>> > events too, perhaps. >>> > >>> >>> As discussed upthread, I have added documentation for all the possible >>> wait events and an example. Some of the LWLocks like AsyncQueueLock and >>> AsyncCtlLock are used for quite similar purpose, so I have kept there >>> explanation as same. >>> >> >> Do you think it worth grouping rows in "wait_event Description" table by >> wait event type? >> > > They are already grouped (implicitly), do you mean to say that we should > add wait event type name as well in that table? > Yes. > If yes, then the only slight worry is that there will lot of repetition in > wait_event_type column, otherwise it is okay. > There is morerows attribute of entry tag in Docbook SGML, it behaves like rowspan in HTML. ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company