On Fri, Mar 4, 2016 at 12:02 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Robert Haas wrote: >> On Wed, Mar 2, 2016 at 8:07 PM, Kyotaro HORIGUCHI >> <horiguchi.kyot...@lab.ntt.co.jp> wrote: >> > Hello, thank you for the comments. >> >> I think we should leave string_length as it is and use a new variable >> >> for character-based length, as in the attached. >> > >> > Basically agreed but I like byte_length for the previous >> > string_length and string_length for string_length_cars. Also >> > text_length is renamed in the attached patch. >> >> I committed this and back-patched this but (1) I avoided changing the >> other functions for now and (2) I gave both the byte length and the >> character length new names to avoid confusion. > > These tweaks appear to have been universally disliked by buildfarm > members.
Crap. Wasn't careful enough, sorry. Will fix shortly. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
