Andrew Dunstan <and...@dunslane.net> writes:
> On 03/08/2016 10:43 AM, Tom Lane wrote:
>> However, there definitely *is* a hard requirement on perl for Windows
>> builds, even from tarballs, and I thought this patch was only about
>> the Windows build?
> Michael's patch proposes to replace the use of sed to generate probes.h
> with the perl equivalent everywhere. That has the advantage that we keep
> to one script to generate probes.h, but it does impose a perl dependency.
Meh.
> We could get around that by shipping probes.h in tarballs, which seems
> like a perfectly reasonable thing to do.
Well, it'd be messier than you think, because you could not just ship
a dummy probes.h, or make would think it was up to date and not replace
it even in a dtrace-using build. You'd have to ship it as something
like "probes.dummy.h" and cp it into place at build time.
On the whole, I'd rather that this patch left the non-Windows side alone.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
