On Mon, Mar 21, 2016 at 3:43 AM, Andrew Dunstan <and...@dunslane.net> wrote: > > > On 03/20/2016 12:02 AM, Michael Paquier wrote: >> >> On Sun, Mar 20, 2016 at 8:06 AM, Andrew Dunstan <and...@dunslane.net> >> wrote: >>> >>> >>> Still to do: the non-perl pieces. >> >> The patch to address locales is the sensitive part. The patch from >> Petr is taking the correct approach though I think that we had better >> simplify it a bit and if possible we had better not rely on the else >> block it introduces. > > > > OK, the please send an updated set of patches for what remains.
Here you go: - 0001 fixes the global declarations of TIMEZONE_GLOBAL and TZNAME_GLOBAL to be WIN32-compliant. I got bitten by that in the ECPG compilation. - 0002, support of VS2015 in the scripts of src/tools/msvc - 0003, this is necessary in order to run the regression tests, details are here: http://www.postgresql.org/message-id/cab7npqtdixxs8cdl8moivh6qfq-1qv9mkn0ayjzybvzv6wc...@mail.gmail.com - 0004 is the fix for locales. This is actually Petr's work upthread, I have updated comments in the code though and did a bit more polishing. This still looks like the cleanest solution we have. Other solutions are mentioned upthread: redeclaration of struct _locale_t in backend code is one. -- Michael
0001-Fix-declaration-of-TIMEZONE_GLOBAL-and-TZNAME_GLOBAL.patch
Description: binary/octet-stream
0002-Add-support-for-VS-2015-in-MSVC-scripts.patch
Description: binary/octet-stream
0003-Fix-non-compliant-boolean-declarations-with-stdbool.patch
Description: binary/octet-stream
0004-Fix-code-page-calculation-for-Visual-Studio-2015.patch
Description: binary/octet-stream
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers