On Thu, Mar 31, 2016 at 10:15 AM, Ian Barwick <i...@2ndquadrant.com> wrote:
> Currently pg_create_physical_replication_slot() may refer to
> the deprecated wal_level setting "archive":

(Adding Peter in CC who committed this patch).

> Patch changes the error message to:
>
>   ERROR:  replication slots can only be used if wal_level is "replica" or 
> "logical"

Sounds right to me.

> Explicitly naming the valid WAL levels matches the wording in the wal_level
> error hint used in a couple of places, i.e.
>
>   "wal_level must be set to "replica" or "logical" at server start."

It is worth telling that Peter and I both had this code in front of
our eyes during the review :) Still we missed that.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to